search

mahf-opt / mahf

A framework for modular construction and evaluation of metaheuristics.
GNU General Public License v3.0
10 stars 0 forks source link

Add behaviour measures #197

Closed HeleNoir closed 3 months ago

HeleNoir commented 3 months ago

Added those behaviour measures which seem most important at the moment.

Possibly there are some (or rather many) improvements to be made to the way I implemented them, so please tell me what you think should be changed.

luleyleo commented 3 months ago

I think you'll have to update the Rust version for the CI to run: https://github.com/mahf-opt/mahf/blob/30a12747cd7f2abe3164454191573913d24f07ad/.github/workflows/ci.yml#L10

Saethox commented 3 months ago

I think once it passes the CI, we're ready to merge.

HeleNoir commented 3 months ago

Could you please take a look at the last error in the CI (@Saethox)? I did not change anything there and I don't understand what's wrong.

Saethox commented 3 months ago

Could you please take a look at the last error in the CI (@Saethox)? I did not change anything there and I don't understand what's wrong.

Seems to be a clippy bug: https://github.com/rust-lang/rust-clippy/issues/12788

Looks like we either need to downgrade our clippy version or remove the #[derive(Derivative)] in favor of a manual implementation of Clone and Copy.

luleyleo commented 3 months ago

Looks like we either need to downgrade our clippy version or remove the #[derive(Derivative)] in favor of a manual implementation of Clone and Copy.

We could also allow non_canonical_clone_impl for now.

Saethox commented 3 months ago

We could also allow non_canonical_clone_impl for now.

True, that's an easier option. Probably needs to be module-wide on utils.rs, I don't think #[allow()] works directly on the derive macro.