search

mahfoozm / YorkURMP

Rate My Professors extension for the YorkU course portal and VSB
GNU General Public License v3.0
12 stars 3 forks source link

Extension shows me Philippe Jean's ratings for Dr. Jean Varghese's class #12

Open unforgettableid opened 4 months ago

unforgettableid commented 4 months ago

Steps to reproduce

  1. Visit https://w2prod.sis.yorku.ca/Apps/WebObjects/cdm.woa/wa/crsq?fa=HH&sj=PSYC&cn=2010&cr=3.00&ay=2023&ss=SU
  2. Click "Summer 2024 Schedule".
  3. Scroll down to Dr. Jean Varghese's section.
  4. Click the link labelled "no ratings on RateMyProfessors".

Observed

I am shown Philippe Jean's ratings page.

Desired

I'd like to see Dr. Jean Varghese's ratings page instead, please.

Conclusion

Thank you for reading this!

unforgettableid commented 3 months ago

Troubleshooting

  1. Open Google Chrome.
  2. Visit: chrome://extensions/?id=cdhfogbjpedkpmapnddalehbjdjahfmp
  3. Click the "service worker" link.
  4. Click "Network".
  5. Leave the DevTools open.
  6. Visit https://w2prod.sis.yorku.ca/Apps/WebObjects/cdm.woa/wa/crsq?fa=HH&sj=PSYC&cn=2010&cr=3.00&ay=2023&ss=SU
  7. Click "Summer 2024 Schedule".
  8. Scroll down to Dr. Jean Varghese's section.
  9. Alt+Tab to DevTools.
  10. Click on the appropriate "graphql" request row.
  11. Click "Response".

Notice that the GraphQL response includes:

  1. Philippe Jean.
  2. Jean Varghese.
  3. Jean Rosenfeld.
  4. Jean Saindon.
  5. Jean Adams.
  6. Jean Noble.
  7. Jean Paul Paluzzi.

Now:

  1. Visit https://www.ratemyprofessors.com/search/professors/1495?q=Jean%20Varghese

Notice that the search results page includes:

  1. Philippe Jean.
  2. Jean Varghese.
  3. Jean Rosenfeld.
  4. Jean Saindon.
  5. Jean Adams.
  6. Jean Noble.
  7. Jean Paul Paluzzi.

Analysis and conclusion

I wonder why RMP returns Jean Varghese as the second search result, instead of the first. Most websites rank search results by relevance. RMP seems not to be doing so. Maybe it would be a good idea for me to contact them.

unforgettableid commented 3 months ago

I've written an email to ask RMP support about the wonky search-results ordering.

unforgettableid commented 3 months ago

Response from upstream

RMP replied to my email: "... This is an issue we are aware of, and our engineers are actively working to repair it now. Please check back soon, as this should be resolved shortly."