mahjerion / Craft-to-Exile-Dissonance

A Minecraft modpack that aims to turn MC into an ARPG similar to Path of Exile and Diablo II. Focused progression and exploration is the main goal of the modpack.
GNU General Public License v3.0
47 stars 11 forks source link

[BUG] Internal Server Crash on Opening Specific Dungeon Chest #308

Closed MDMeaux closed 2 years ago

MDMeaux commented 3 years ago

Technical specs Craft to Exile Version 2.12.0b World Type [singleplayer] RAM [6GB]

Describe Bug When attempting to open a chest in a dungeon, the internal server seems to crash (I can still move around etc. but it looks like the server stops ticking). Initially noticed with Optifine, but tried removing and crash still happened without Optifine. The game doesn't crash completely, but when I try and Save and Exit, it just gets stuck on Saving World, so I have to Kill the game, and there is no crash report generated. When I reload the world after the crash, it takes me back a minute or so before I opened the chest initially, but opening the chest again has the same outcome (same crash happened 3 times with Optifine and once without).

To reproduce I have attached the world file if that helps (location of the chest can be seen on debug screen info). I have also attached 2 recordings of the bug occuring, with the debug screen open and the TPS graph to show how the TPS seem to just stop as soon as the chest is clicked.

Expected behaviour The chest opens normally and the game doesn't crash.

Additional information World file: https://drive.google.com/file/d/17_NmDHmcGb33bXM_Pm94wHwNCqlc18Tw/view?usp=sharing Crash happening (w/. Optifine): https://drive.google.com/file/d/18gcKWeXQ0_yYQmbT4GTayNhvgpqrbDlT/view?usp=sharing Crash (w/o Optifine): https://drive.google.com/file/d/1WMqJsf0u97o6kYgA61912jk7AAei5I_l/view?usp=sharing

roatigern commented 3 years ago

if there is a crash there must be a crashlog.... would you be able to upload that?

MDMeaux commented 3 years ago

The game doesn't crash completely, so there is no crash report generated. It keeps running after the 'crash' but nothing in the world updates anymore. I've just tried reproducing the issue again and there's nothing in the log either.

roatigern commented 3 years ago

if it crashes everytime you open that one chest i guess there is an item in it that isnt supposed to be there

MDMeaux commented 3 years ago

I've run a /data get block command on the chest and since the chest hasn't been opened yet it only gives the loot table as the loot hasn't been rolled yet. Image of the result is attached. I've looked at the dungeon_loot_husk.json file in the dungeons-plus jar file and the only unique bit of the loot table is a "minecraft:exploration_map" for a "dungeons_plus:leviathan" so my assumption is that is what's causing the issue. image

mahjerion commented 3 years ago

Thanks for the post. I can't seem to access your crash reports/logs because they're on drive. Could you upload them to Pastebin or something instead? Thanks!

MDMeaux commented 3 years ago

There are no crash reports because the game didn't crash entirely, it kept running after the 'crash', but the world stopped updating (and froze when I tried to save and exit) so my only option was to kill the game. The links are to the world file and 2 videos of the crash happening. I see that the links don't work properly when you click them on Github, but I think they should work if you copy paste the link.

mahjerion commented 2 years ago

should be fixed as well, see #406