Function name overwrites built-in function

mahmoodlab / CLAM

Data-efficient and weakly supervised computational pathology on whole slide images - Nature Biomedical Engineering

http://clam.mahmoodlab.org

GNU General Public License v3.0

1.02k stars 340 forks source link

Function name overwrites built-in function #188

Closed research-police closed 1 year ago

research-police commented 1 year ago

We patrolled your repo and found the following: https://github.com/mahmoodlab/CLAM/blob/9482cbc72df522087cfbaa3e6b52da5207a7980a/utils/eval_utils.py#L48

This obviously overwrites the built-in Python function eval(...) This is especially bad practice, since the overwriting function is star imported (please also refer to #187) and behaves completely different from the built-in function.

fedshyvana commented 1 year ago

Hey thanks for noting - for any suggestions regarding code refactoring/organization, please feel free to open a PR. Any contribution to improving the code base is always welcome : )