mahmoodlab / PANTHER

Morphological Prototyping for Unsupervised Slide Representation Learning in Computational Pathology - CVPR 2024
Other
97 stars 11 forks source link

Doubt regarding expectation maximization #14

Closed Rukhmini closed 2 months ago

Rukhmini commented 2 months ago

Hello, I noticed that in your implementation of the PANTHER model, the forward function calls the map_em method, which performs both the Expectation and Maximization (EM) steps of the algorithm. Specifically, the forward function estimates the parameters pi, mu, and Sigma, and then stacks them. However, traditionally in GMM, the workflow separates the fit (EM algorithm on training data) and predict (using the learned parameters on test data) steps. Since the map_em method includes both the Expectation and Maximization steps, which is typically associated with fitting the model, it seems unusual to include the Maximization step in the forward pass. Could you explain why the PANTHER model doesn't follow the traditional GMM structure with separate fit and predict steps, and why the Maximization step is included during the forward pass? How does this design choice affect the model's training and inference processes? Thanks.

andrewsong90 commented 2 months ago

Hi @Rukhmini

Yes, there are several possible answers to this.

Hope this helps!