search

mahmoud / boltons

🔩 Like builtins, but boltons. 250+ constructs, recipes, and snippets which extend (and rely on nothing but) the Python standard library. Nothing like Michael Bolton.
https://boltons.readthedocs.org
Other
6.54k stars 353 forks source link

Use license_files instead of license_file in setup.cfg #357

Closed bkmgit closed 11 months ago

bkmgit commented 11 months ago

Use license_files instead

bkmgit commented 11 months ago

See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#metadata

mahmoud commented 11 months ago

Interesting, though that link doesn't specify that license_file is deprecated, just that it has a new alias. Is there another source you can point me to? Can you elaborate on why we'd introduce an implicit minimum version of setuptools (42.0.0)?

bkmgit commented 11 months ago

This is a warning that came up when building for inclusion on Fedora linux. See the log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252017-python-boltons/fedora-rawhide-x86_64/06705253-python-boltons/builder-live.log.gz

Is there a good way to support multiple versions of setuptools/python?

mahmoud commented 11 months ago

Got it, thanks for the log. I've opened an issue on setuptools to update their docs: https://github.com/pypa/setuptools/issues/4147

As for version management, I think we're ok to upgrade. I looked up the setuptools version and any version released after 2019 should be fine. We could add setuptools>42 or something to setup_requires, but that'd mostly be as a form of documentation.