search

mahmoud / glom

☄️ Python's nested data operator (and CLI), for all your declarative restructuring needs. Got data? Glom it! ☄️
https://glom.readthedocs.io
Other
1.89k stars 61 forks source link

Add minimum required face version in setup.py #188

Closed Dunedan closed 4 years ago

Dunedan commented 4 years ago

Since version 20.7.0 glom requires at least version 20.1.0 of face, as that's the version of face where face.helpers.get_wrap_width got added. This commit adds the version 20.1.0 of face to the required dependencies in setup.py, to avoid incompatbilities with environments which provide older versions of face.

codecov[bot] commented 4 years ago

Codecov Report

Merging #188 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          26       26           
  Lines        4030     4030           
  Branches      575      575           
=======================================
  Hits         3985     3985           
  Misses         21       21           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4e2f2c...c3caea7. Read the comment docs.

mahmoud commented 4 years ago

Great point, good catch, nice fix, thank you!