Replace deprecated imp module with importlib - Githubissues

mahmoud / glom

☄️ Python's nested data operator (and CLI), for all your declarative restructuring needs. Got data? Glom it! ☄️

https://glom.readthedocs.io

Other

1.88k stars 61 forks source link

Replace deprecated imp module with importlib #261

Closed hugovk closed 6 months ago

hugovk commented 1 year ago

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Raised PendingDeprecationWarning since 3.4 (2014)
Raised DeprecationWarning since 3.5 (2015)
Updated DeprecationWarning to say removal in 3.12 since 3.10 (2021)
Removal planned for 3.12 (2023)

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

sfermigier commented 6 months ago

Tests pass under Python 3.12, so I guess this has been fixed.

hugovk commented 6 months ago

👍

I've opened https://github.com/mahmoud/glom/pull/283 to add 3.12 to the CI.