search

mahmoud2 / pinguino32

Automatically exported from code.google.com/p/pinguino32
0 stars 0 forks source link

Code review request #41

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:
Keypad Library repeat issue

Purpose of code changes on this branch:
Correct repeated key in the same column , by checking the state to not be 
pressed , for validate key.

When reviewing my code changes, please focus on:

...
EVALUATE_KEY:
//if (key != NO_KEY && key != currentKey ){ 

//Correction for simultaneous pressed keys on the same row
if (key != NO_KEY && key != currentKey && state!=PRESSED){     

        // if(state ==HOLD && key != currentKey) //try to disable several keys pressed at the same time
        //     return NO_KEY;

        currentKey = key;
        Keypad_transitionTo(PRESSED);

        return currentKey;
    } 

...

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by fabio.malagas@gmail.com on 1 Mar 2013 at 10:32

GoogleCodeExporter commented 9 years ago 
Hi Fabio,
May I close this one ?

Original comment by rblanchot@gmail.com on 23 Apr 2013 at 8:07

GoogleCodeExporter commented 9 years ago 
Hi there.
It's been a while... Yes, as it was commited day's ago on p8 and p32
targets.

Best Regards.

Original comment by fabio.malagas@gmail.com on 23 Apr 2013 at 8:09