search

mahmoudbasha / minimalist

Automatically exported from code.google.com/p/minimalist
0 stars 0 forks source link

Custom colors corrupted on save by hex validator #170

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What is the problem? Describe completely:

Minimalist version   - 0.5.17
Relevant core module - Minimalist for Gmail - Version 2.0.9
Chrome version       - 16.0.912.75 m
Operating System     - Windows 7
Language             - English
Google Apps user?    - Y
Other extensions     - Various

Love this extension but just ran into a problem today. Highlight colors defined 
in the Main/Row section are no longer being displayed. They were working fine 
yesterday but today they are no longer visible. I think this may be a Version 
2.0.9 issue because they are still working fine on my other PC which is on 
Version 2.0.8 (however, it is running Vista rather than Win 7). On the problem 
PC I notice that the color settings are now being displayed as #rgba(x,y,z,a) 
but the values entered do not appear to be persistent i.e. when I select a 
given highlight color and save the changes they are no longer there the next 
time I open the Minimalist options tab  - they always revert back to 
#rgba(255,255,255,1).

Please help!

Peter Skinner

Original issue reported on code.google.com by ptskin...@gmail.com on 12 Jan 2012 at 1:26

GoogleCodeExporter commented 8 years ago 
Sorry! Fixed in 0.5.20. I switched from hex to rgba colors to allow 
transparency but I was still enforcing hex format in validation which was 
causing colors to be corrupted and reset. It is fixed now. Here are the default 
colors:

Read:     rgba(243,243,243,1)
Unread:   rgba(117,180,75,1)
Starred:  rgba(255,248,176,1)
Checked:  rgba(237,98,84,1)
Selected: rgba(94,171,255,1)

Original comment by anst...@gmail.com on 12 Jan 2012 at 3:51

GoogleCodeExporter commented 8 years ago 
Many thanks for the super swift fix - much appreciated.

Original comment by ptskin...@gmail.com on 12 Jan 2012 at 4:17