search

mahmoudbasha / minimalist

Automatically exported from code.google.com/p/minimalist
0 stars 0 forks source link

Edit page ignores options which have no section #289

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What is the problem? Describe completely:

Minimalist version   - 0.6.4
Relevant core module - Gmail
Chrome version       - 24.0.1312.57
Operating System     - osx 10.8.2
Language             - English
Google Apps user?    - Yes
Other extensions     - Vimium and others...this isn't related

Please provide any additional information below and attach screenshots if
relevant.

I spent a good while coding up some custom settings, to make lots of things 
disappear nicely without taking away functionality.

They were placed under General-> General  whenever I added them
I moved them all to General (i.e., one level up, under the tab instead of under 
the Section under the Tab) and then they disappeared from view.

I can still access them from my options menu, but they are hidden from the edit 
menu.

To see what i mean, here's the options image
https://www.evernote.com/shard/s84/sh/9418444b-09d0-4f27-b10c-cee4bf2e41ef/a4e59
585130db9f65c2ae84624179810/deep/0/Screenshot%202/3/13%2011:44%20PM.jpg

Heres the edit message
https://www.evernote.com/shard/s84/sh/a85fa624-39e1-4b53-9d4d-aeb10b43cb20/f06b3
82c511dc3a135e805f8ad650a50/deep/0/Screenshot%202/3/13%2011:45%20PM.jpg

Thanks a bunch!
Mike

Original issue reported on code.google.com by michaelp...@gmail.com on 4 Feb 2013 at 7:47

GoogleCodeExporter commented 8 years ago 
Hi Mike,

The UI assumes that every option will have a tab and a section, however I can 
see the benefit of leaving it blank, I will make the UI handle this better in 
the next version.

However, before the next version comes out, please move your custom code into a 
new module. Whenever there is an update, all of the code for the core modules 
is overwritten. If go to Data > Export > Specific Modules > Gmail and attach a 
text file with the results, I will repair it for you and move your custom 
features into a new module.

Original comment by anst...@gmail.com on 4 Feb 2013 at 4:06

GoogleCodeExporter commented 8 years ago 
HI Ansel � thanks for being so responsive.

Here are the settings from this morning. It looks like its no longer even
registering my custom scripts. Hopefully they're still in there.

Original comment by michaelp...@gmail.com on 4 Feb 2013 at 6:31

GoogleCodeExporter commented 8 years ago 
Your attachment might not have come through, please try and attach it directly 
via the issue tracker page.

Original comment by anst...@gmail.com on 4 Feb 2013 at 6:32

GoogleCodeExporter commented 8 years ago 
Hi Ansel � Apologies, I didn't double check first to make sure that my code
definitely wasnt deleted.

This should help. Fortunately I had a version of it from earlier in my
clipboard history when i was trying to debug it.

Original comment by michaelp...@gmail.com on 4 Feb 2013 at 6:33

GoogleCodeExporter commented 8 years ago 
Ah — ok

Hopefully this works. 

Cheers,
Mike

Original comment by michaelp...@gmail.com on 4 Feb 2013 at 6:34

Attachments:

GoogleCodeExporter commented 8 years ago 
Perfect, your code is all still there, the injection script treats the options 
the same way the edit page does so if it's missing sections, it may not be 
injected.

Import from the attached code to get your options repaired and in a new module.

Original comment by anst...@gmail.com on 4 Feb 2013 at 6:43

Attachments:

GoogleCodeExporter commented 8 years ago 
Just as a heads up — the syncing doesn't seem to be working with the external 
modules. It got the structure, but didn't import any of the code. E.g., instead 
of General→General it said undefined→undefined.

Fortunately I have the code right here, but I figure that's a good thing to 
know.

Original comment by michaelp...@gmail.com on 4 Feb 2013 at 8:18

GoogleCodeExporter commented 8 years ago 
Yes, syncing is metered and so to minimize data transfer I'm just syncing 
options right now and not the actual contents of the modules. I will probably 
enable syncing contents of non-core modules in the next update.

Original comment by anst...@gmail.com on 4 Feb 2013 at 8:20

GoogleCodeExporter commented 8 years ago 
Ah, that makes sense. 

I have no idea how this would be implemented on the extension side... but one 
thought to reduce data transfer on your end, would be to include secondary 
option to sync via a pointer to a public dropbox folder (or to a set of files' 
hyperlinks). It'd be pretty easy to store all of the modules there and then you 
could offload the syncing load to dropbox which (since everything can be stored 
as a textfile) should work pretty efficiently.

Original comment by michaelp...@gmail.com on 4 Feb 2013 at 9:07

GoogleCodeExporter commented 8 years ago 
Good point and I will keep third party options in mind, however I would like to 
stick with the Chrome APIs as much as possible. For reference:

Sync Storage: 102,400 bytes (~17k chars, worst case)
Stripped core modules size: ~7k chars

So worst case, I have about 10k chars to use to sync non-core modules. That's 
plenty for now

Original comment by anst...@gmail.com on 4 Feb 2013 at 10:10