search

mahmoudimus / nose-timer

A timer plugin for nosetests (how much time does every test take?)
MIT License
126 stars 33 forks source link

Improved timing results coloring #27

Closed skudriashev closed 10 years ago

skudriashev commented 10 years ago

Documentation says: "Tests which takes less time than --timer-ok will be highlighted green.", but actually they are not highlighted (because of the bug). This patch makes "ok" tests to be highlighted with green. Moreover, I propose to use the "termcolor" package for coloring, this simplifies code a little bit.

skudriashev commented 10 years ago

Guys, what do you think about this one?

mahmoudimus commented 10 years ago

@skudriashev I prefer not introducing a dependency. Maybe let's package the file alongside the plugin instead?

mahmoudimus commented 10 years ago

@e0ne what are your thoughts on this?

skudriashev commented 10 years ago

@mahmoudimus, thanks for your response! Personally I think that depending on the package is not a problem at all (many other packages do). Moreover, termcolor is quite stable and have been used in several projects I've seen. I think there is no sense to keep package file alongside.

What do you think are advantages to keep it alongside?

mahmoudimus commented 10 years ago

@e0ne thoughts?

e0ne commented 10 years ago

@mahmoudimus, I'm not against a new dependency.

skudriashev commented 10 years ago

@mahmoudimus, @e0ne So, is this PR fine?

mahmoudimus commented 10 years ago

@skudriashev y looks fine, can you fix merge conflict and update pull request, bump version and we're ready to release this?

skudriashev commented 10 years ago

Done.

mahmoudimus commented 10 years ago

Thanks @skudriashev !