search

mahmoudimus / nose-timer

A timer plugin for nosetests (how much time does every test take?)
MIT License
126 stars 33 forks source link

Don't install mock package twice #35

Closed skudriashev closed 10 years ago

e0ne commented 10 years ago

@skudriashev, why do you need this patch? mock it pre-installed only on Travis CI env and in Python 3.3+

skudriashev commented 10 years ago

@e0ne, sorry, looks like I didn't get you point..) From the tox.ini file I see that the mock package is installed for each environment (the deps parameter). If I understand it correctly it is not needed to install it by Travis CI (at least testing results claim this). Maybe I'm wrong, if installing this package is required for some reason, could you, please, explain why? Thanks!

skudriashev commented 10 years ago

So, @e0ne, what do you think? Thanks!

skudriashev commented 10 years ago

Hi, @e0ne, any updates? Thanks!

mahmoudimus commented 10 years ago

@skudriashev does this really matter though? pip will detect mock is installed and moved on right? what's the big deal about leaving it here?

skudriashev commented 10 years ago

@mahmoudimus, you're right, this is not a big deal. Just a small clean-up. Actually, we can leave it like it is now.