search

mahmoudimus / nose-timer

A timer plugin for nosetests (how much time does every test take?)
MIT License
126 stars 33 forks source link

Add PyPy to Travis CI #52

Closed hugovk closed 9 years ago

hugovk commented 9 years ago

It passes :)

skudriashev commented 9 years ago

@hugovk, please, add PyPy to setup.py.

hugovk commented 9 years ago

@skudriashev Currently setup.py has:

        'Programming Language :: Python',
        'Programming Language :: Python :: 2',
        'Programming Language :: Python :: 2.6',
        'Programming Language :: Python :: 2.7',
        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.3',

I'll add 3.4 there too.

The only Pypy one here https://pypi.python.org/pypi?%3Aaction=list_classifiers is:

Programming Language :: Python :: Implementation :: PyPy

So shall I also add CPython?

Programming Language :: Python :: Implementation :: CPython
skudriashev commented 9 years ago

@hugovk, thanks!

Merged.

hugovk commented 9 years ago

@skudriashev https://github.com/mahmoudimus/nose-timer/pull/53 contains the setup.py changes.

mahmoudimus commented 9 years ago

Ok, this brings up an interesting point. I think it makes sense to re-open https://github.com/mahmoudimus/nose-timer/issues/12 and take another look. If we develop for PyPy and all these different python versions, I think it should be easy for whomever is contributing to just vagrant up and hack away to fix any bugs. Thoughts @skudriashev @e0ne ?

hugovk commented 9 years ago

Would virtualenv suit?

mahmoudimus commented 9 years ago

@hugovk how many virtualenvs would you really need? That's what tox supports already, but think about when developing a particular bug for a particular version.

I anticipate that it's going to require a non-zero upfront cost for an experienced python developer to really fix a bug in nose-timer, since we support a lot of python versions, which can be frustrating. Given that, I wonder how we can make the experience better? I think vagrant + tox is one way, but I think just virtualenv or tox by itself is necessary but insufficient.