search

mahmoudimus / nose-timer

A timer plugin for nosetests (how much time does every test take?)
MIT License
126 stars 33 forks source link

setup.py changes for #52 #53

Closed hugovk closed 9 years ago

hugovk commented 9 years ago

setup.py changes for https://github.com/mahmoudimus/nose-timer/pull/52

mahmoudimus commented 9 years ago

:+1: from me! Thanks @hugovk! can you please add yourself to the https://github.com/mahmoudimus/nose-timer#contributors list by also modifying README.rst?

hugovk commented 9 years ago

@mahmoudimus Done!

skudriashev commented 9 years ago

Merged.

hugovk commented 9 years ago

@skudriashev I'm curious, how did you merge this? GitHub says:

Closed with unmerged commits

,This pull request is closed, but the hugovk:pypy branch has unmerged commits.

But I can see it is merged. I guess you didn't use the web UI. Thanks!

skudriashev commented 9 years ago

@hugovk, you are right, I don't use web UI:)

hugovk commented 9 years ago

@skudriashev How exactly? And what's the main benefit? Thanks!

skudriashev commented 9 years ago

@hugovk, just personal preference.