Closed Zitrax closed 9 years ago
Hi @Zitrax, from your traceback, I see C:\...
which suggests that you're on a Windows platform, which we currently do not support. However, try pull request #60 and #62, by @ereOn, to see if this fixes the problem for you.
@mahmoudimus Any reason to not support Windows ? Seems a bit weird to restrict a Python tool to a specific set of platforms especially when the fixes to make it work (even in a diminished capacity) are trivial.
I don't like Windows personally, but some people just don't have a choice. Do you plan to never support Windows ? If so please let me know, I'll be happy to fork.
I would love Windows support! However, I think the problem mostly stems from a couple of things:
That all being said, I would love an active co-maintainer that can help maintain Windows compatibility on this plugin. The operative word is active. Once it goes in, it has to continue being supported. Would you be up for it, @ereOn? Also, we would need help on windows support for the upcoming nose2 plugin.
@ereOn - maybe explore integrating http://www.appveyor.com/ ?
So I tried to clone the repo and install from source and then it worked fine. I have not verified the difference - but at least it worked.
One note though, on Windows color output will not work by default in cmd, so perhaps the --timer-no-color
should be default on this platform ?
@Zitrax : That's funny, because it is also a PR that I have that is pending (it's actually been a while) - See https://github.com/mahmoudimus/nose-timer/pull/61.
@mahmoudimus I sadly can't commit to maintain yet another project. That being said, it seems to me that if you have a good test coverage & continuous integration on Linux, you can still accept Windows contributions (you'll know for sure when something breaks on the Linux side, which is what you commit to support). Just specify in the README that Windows support is unofficially supported but that patches are welcome. You'll get the best of both worlds.
@e0ne, looks like @skudriashev granted your wish: https://github.com/mahmoudimus/nose-timer/pull/62#event-328729224 :-)
@Zitrax, pull from master for windows fix! @ereOn please submit a pull request adding yourself to the contributors list below :-)
@Zitrax @ereOn - This is solved by merging in pull requests #61, #62, and #64.
@Zitrax @e0ne with https://github.com/mahmoudimus/nose-timer/pull/65 merged, can you guys try 0.5 out to see if no regressions occurred?
I installed 0.4.4 and got the following when trying to run any nosetests: