search

mahmoudimus / nose-timer

A timer plugin for nosetests (how much time does every test take?)
MIT License
126 stars 33 forks source link

Made termcolor not required dependency, but optional. #70

Closed gewthen closed 8 years ago

gewthen commented 8 years ago

I'm not certain of the process for submitting pull requests, but I thought I would just present one that might make nose-time a bit more usable for those who might be having trouble installing termcolor or has no reason to install it in automated test systems.

The change makes it such as termcolor is only used for colorizing the output only when it is installed. If it is not installed, then just plain text is used.

gewthen commented 8 years ago

Not certain why the python 3.2 environment is failing. Any help would be appreciated.

mahmoudimus commented 8 years ago

@gewthen https://travis-ci.org/mahmoudimus/nose-timer/jobs/104332296#L150.

skudriashev commented 8 years ago

@gewthen, I would agree with @mahmoudimus - need to do it in Pythonic way. Thanks!

skudriashev commented 8 years ago

@gewthen, Also, I think you need to reflect this change in documentation. Thanks!

mahmoudimus commented 8 years ago

@gewthen did you want to take another stab at this or would you like us to fix it up?

gewthen commented 8 years ago

You are welcome to fix it up.

On Thu, Feb 11, 2016 at 2:26 PM, Mahmoud Abdelkader < notifications@github.com> wrote:

@gewthen https://github.com/gewthen did you want to take another stab at this or would you like us to fix it up?

— Reply to this email directly or view it on GitHub https://github.com/mahmoudimus/nose-timer/pull/70#issuecomment-183021043 .

skudriashev commented 8 years ago

Closing since no activity.

stuertz commented 6 years ago

Hi, I would like to reopen the issue and may also supply the finished patch, if there is a chance to get this into the repo. Another thought I have is to replace termcolor by using the more widespread colorama.

What do you think?