mahmoudimus / nose-timer

A timer plugin for nosetests (how much time does every test take?)
MIT License
126 stars 33 forks source link

Why BSD 4-Clause? #72

Closed jakirkham closed 7 years ago

jakirkham commented 8 years ago

Trying to understand why the BSD 4-Clause is present here. It is known that the advertising clause causes serious problems. So, I am trying to understand why it was added and whether it can be removed (i.e. the license converted to BSD 3-Clause or similar).

mahmoudimus commented 8 years ago

@jakirkham Hmm, my intention was not to make this BSD 4-Clause. It should definitely be either MIT/BSD dual-licensed or Apache 2.0 License. Any preference?

jakirkham commented 8 years ago

Not particularly. As long as the number of BSD clauses are less than 4 (assuming it stays BSD), I am happy.

mahmoudimus commented 8 years ago

@skudriashev any preference?

skudriashev commented 8 years ago

@mahmoudimus, not really. MIT would be fine I guess.

jakirkham commented 7 years ago

Should I submit a PR to make it MIT then?

mahmoudimus commented 7 years ago

@jakirkham would appreciate that! also add yourself to the contributors list please!

MrEbbinghaus commented 7 years ago

@jakirkham @mahmoudimus Is this a thing anymore?

e0ne commented 7 years ago

Looks like we're OK to close this issue.

jakirkham commented 7 years ago

Why? It doesn't appear to be fixed.

jakirkham commented 7 years ago

Please see PR ( https://github.com/mahmoudimus/nose-timer/pull/81 ) for the fix.

e0ne commented 7 years ago

@jakirkham I'm sorry, we still have both licenses

jakirkham commented 7 years ago

No worries.