search

mahmoudimus / nose-timer

A timer plugin for nosetests (how much time does every test take?)
MIT License
126 stars 33 forks source link

Add --timer-fail option to fail tests that exceed threshold #89

Closed acordiner closed 6 years ago

acordiner commented 6 years ago

This is my attempt at implementing the first part of #88. I haven't worked with nose plugins before (and the documentation is quite terse) so let me know if there's a better approach you had in mind!

mahmoudimus commented 6 years ago

Hi @acordiner thanks for the PR! Either @skudriashev or I will review shortly :) Thank you!

skudriashev commented 6 years ago

@acordiner please update the README.rst. Thanks for your contribution 👍

skudriashev commented 6 years ago

@acordiner also please fix your commit message within 50 symbols.

First line is 50 characters or less Then a blank line Remaining text should be wrapped at 72 characters

https://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting

acordiner commented 6 years ago

@skudriashev - I've made the changes, let me know if it looks okay.

skudriashev commented 6 years ago

LGTM

skudriashev commented 6 years ago

@mahmoudimus please do a final approve :)

acordiner commented 6 years ago

Any updates on this pull request?

mahmoudimus commented 6 years ago

Whoops, apologies. This looks good to me! :shipit:

acordiner commented 6 years ago

Thanks!

mahmoudimus commented 6 years ago

@acordiner cut a release for tag v0.7.3! should be on pypi shortly. cheers!

mahmoudimus commented 6 years ago

https://travis-ci.org/mahmoudimus/nose-timer/builds/402054014 status on that.