search

mahmoudimus / sqlalchemy-citext

CITEXT type for SQLAlchemy
Other
29 stars 14 forks source link

FYI: PR in to sqlacodegen #18

Closed mzpqnxow closed 3 years ago

mzpqnxow commented 3 years ago

Hello,

Thanks for your work on this project, it's made my life much simpler :>

I wanted to let you know that I submitted a PR to the sqlacodegen tool that incorporates sqlalchemy-citext as an extra. This allows sqlacodegen to produce classes cleanly without any complaints or manual fixups when one of the columns is a CITEXT type. Without this PR, it fails to recognize the column type and emits a NULL column type. This is easy to fix manually, but it also fails to add other metadata for the column such as the default values, etc.

It seems that the sqlacodegen project is looking for a new maintainer however, so the PR has not been accepted or commented on

I thought I would just put this in as a note. There is no action required in sqlalchemy-citext, it's more just to make you and other users aware. I don't know how popular sqlacodegen is, but I use it exclusively because it's boring and annoying manually writing up classes for tables.

Thanks again, please feel free to close this issue

mahmoudimus commented 3 years ago

That’s awesome! If needed, we can help maintain sqlacodegen— thanks for letting us know!