search

mahnuh / capacitor-plugin-app-tracking-transparency

Capacitor plugin to request user authorization to access app-related data for tracking the user or the device.
MIT License
33 stars 10 forks source link

Bump to Capacitor 5? #16

Closed nasasutisna closed 1 year ago

nasasutisna commented 1 year ago

will this plugin support capacitor 5?

mahnuh commented 1 year ago

Hi @nasasutisna it does actually. If you are having issues with Capacitor 5 and the most recent version of this plugin, please open another issue with detailed information on how to reproduce these issues.

mahnuh commented 1 year ago

@nasasutisna please have a look at this demo app using Capacitor 5 and the current version of my plugin. Everything works fine for me.

naranjamecanica commented 1 year ago

@mahnuh Just a small comment instead of a new issue.

My setup complains that the deploy target is to low, capacitor needs iOS 13, and you specify iOS 12, see: https://github.com/mahnuh/capacitor-plugin-app-tracking-transparency/blob/1238c06737c21f985059ee4130cfc7699e7fab9f/CapacitorPluginAppTrackingTransparency.podspec#LL14C35-L14C35

(using capacitor 4.8.0)

mahnuh commented 1 year ago

@naranjamecanica Can you please tell me how your setup complains? Is it anwarning or error, du you need to change something to be able to build?

naranjamecanica commented 1 year ago

@mahnuh when running npx cap sync it complained that a higher iOS version was demanded. I've changed the value in your podspec and then it went away.

✖ update ios - failed!
[error] Analyzing dependencies
        [!] CocoaPods could not find compatible versions for pod "Capacitor":
        In Podfile:
        Capacitor (from `../../node_modules/@capacitor/ios`)

        Specs satisfying the `Capacitor (from
        `../../node_modules/@capacitor/ios`)` dependency were found, but they
        required a higher minimum deployment target.
mahnuh commented 1 year ago

@naranjamecanica please see this comment, does that help in your case?

naranjamecanica commented 1 year ago

@mahnuh 👍🏻 yes it helps, the only thing is I started a fresh capacitor project, it was not an upgrade from 3... So that's a bit confusing..

Danke!

mahnuh commented 1 year ago

Ok, that is interesting. I'm going to have a look in the next days or so and maybe update the README. Thanks for your input!

naranjamecanica commented 1 year ago

Hmm the template file also looks fine... https://github.com/ionic-team/capacitor/blob/main/ios-template/App/Podfile Maybe there was a mix of old and new files in my project... 🍻