search

mahnunchik / gulp-responsive

gulp-responsive generates images at different sizes
https://npmjs.com/gulp-responsive
MIT License
503 stars 60 forks source link

Promisify some sharp calls #106

Closed rejas closed 5 years ago

rejas commented 6 years ago

While tinkering around #65 I noticed that some calls to the sharp-library could be used with promises. Makes some cleaner code. Also fixed some deprecation warning with latest sharp lib (sharp deprecations will be fixed in a different PR Comments? Improvement ideas?

rejas commented 5 years ago

Hi @mahnunchik any chance to get thi smerged? Or dont you have time for this plugin anymore?

mahnunchik commented 5 years ago

@rejas hi, is it breaking change?

rejas commented 5 years ago

No, no breaking changes in there which I could think of.

mahnunchik commented 5 years ago

Done!