search

mahnunchik / gulp-responsive

gulp-responsive generates images at different sizes
https://npmjs.com/gulp-responsive
MIT License
503 stars 60 forks source link

Sharp fit #146

Open seb-celinedesign opened 4 years ago

seb-celinedesign commented 4 years ago

Add the new Sharp fit parameter as a configuration option. Replace the deprecated max parameter.

StarpTech commented 4 years ago

Hi @CelineDesign, could you add a test?

seb-celinedesign commented 4 years ago

Hi, just add the fit option in the config object and a test for it. Is that what you wanted ?

StarpTech commented 4 years ago

I mean a test that guarantees the correct output.

seb-celinedesign commented 4 years ago

I mean a test that guarantees the correct output.

By "correct output" do you mean the file at the right dimension ? Because none of the current test is testing the generated image file and his properties. I think the role of gulp-responsive is to pass correct params to the Sharp library, which is the one who manipulate image files.