maho3 / ltu-cmass

A modular simulator of CMASS-NGC galaxy clustering
6 stars 1 forks source link

Move cuboid remapping to ngc_selection script and update #41

Closed maho3 closed 3 days ago

maho3 commented 1 week ago

This PR moves the code in cmass/survey/remap_cuboid.py into a helper function within cmass/survey/ngc_selection.py, for the reasons discussed in #40.

Changes:

All of the above has been validated in matts_tests/test_remove_cuboid.py

maho3 commented 1 week ago

Here are some plots showing that the new move_to_footprint centers the simulation box over the survey footprint.

Simulation cuboid wrapping the survey volume, when it has been transformed to the origin. image

Simulation box overlapping with the survey footprint in comoving space (without transformations). image