maho3 / ltu-ili

Robust ML in Astro
https://ltu-ili.readthedocs.io/en/latest/
45 stars 9 forks source link

Rename or remove thetaobs #114

Closed maho3 closed 10 months ago

maho3 commented 11 months ago

SBISimulator data loader class allows you to specify xobs and thetaobs. thetaobs is then mostly ignored, unless its used for PlotSinglePosterior in validation.

For a new user, it may be unclear to think about what xobs and thetaobs are, as, in an observational context, we never have access to the real thetaobs.

I propose we remove thetaobs and its integration with the validation section, or at least rename it to theta_fid or theta_ref something less ambiguous.

Brought up by @laperezNYC