search

maho3 / ltu-ili

Robust ML in Astro
https://ltu-ili.readthedocs.io/en/latest/
46 stars 9 forks source link

SBIRunnerSequential is very different from SBIRunner #117

Closed maho3 closed 11 months ago

maho3 commented 11 months ago

The precedent of naming conventions and handling of training summaries is different between SBIRunner and SBISequentialRunner. These need to be self-consistent, and perhaps can use helper functions to reduce the complexity.

maho3 commented 11 months ago

Also, SBISimulator has a problem that it overwrites the files at self.x_path and self.theta_path when new sims are run. this should not be default.

maho3 commented 11 months ago

Also, we should be able to specify x_obs in the StaticNumpyLoader. This propagates to how we find xobs in Validation. Check diff with paperv1 branch