maho3 / ltu-ili

Robust ML in Astro
https://ltu-ili.readthedocs.io/en/latest/
46 stars 9 forks source link

Lampe direct samplers take along time for poorly constrained posteriors #151

Closed maho3 closed 23 hours ago

maho3 commented 6 months ago

This is caused by our cutting of posterior samples to within the prior support. Basically, most samples are falling outside of the prior support, causing a long time to find num_samples samples. The problem is here: https://github.com/maho3/ltu-ili/blob/430482eaaba654fcd27ca736a89f24d8ae5a973d/ili/utils/ndes_pt.py#L164

There's not much we can do about this technically, but it would be nice to provide a warning that most posterior samples are falling outside the prior support.

Suggested by @christopherlovell