Closed maho3 closed 1 year ago
A lot of minor changes have occurred in this PR, resulting in many files changed. The primary functionality remains exactly the same, this PR is just to make everything consistent over the past series of changes. Here's a summary:
For reviewers Since a lot of files changed, it will be difficult to check everything of them. So I recommend you check that at
Note, SNLE/SNRE support and custom sampling will be added in PR #54 .
Replies to checks:
Try installing the sbi and pydelfi version (pydelfi will only work with Python 3.6 on a Linux machine).
Installing pydelfi in a fresh environment led to a few errors. I have updated the setup.cfg file to change the dependencies to remove this
Try compiling the docs and make sure they have all the information you'd need.
I compiled these without issues locally (some warnings were raised, but did not affect the result).
I see no issues with the code structure
Other changes I have made:
else
statement in https://github.com/maho3/ltu-ili/blob/823faa50c3672096153636d806bb68b164ed38de/ili/validation/runner.py#L111. This has been addedA request:
Cleanup and refactoring of ltu-ili after many changes over the last months. Addresses #52.