SitePro Fix

[gilect-com]

Fixed SitePro from creating a website in the wrong directory, when using a domain other than the Account Domain. Previously it was created at /htdocs/domain When it should be at /domain/htdocs instead

[greenreader9]

DO NOT DO THIS!!!

This is will break the base domain of the account (The domain that the account was created with).

The solution is to programmatically determine what to do, there is not a "Always This" or "Always That" solution.

[gilect-com]

Why exactly is this breaking the original domain?

All this is doing is preventing files from being created in /htdocs/domain (a directory which does not exist) Instead they should be created in /domain/htdocs/

Using the website builder on the original Account Domain still works fine, it creates the files in /htdocs/

[4yx]

This will break original domain on the account

Could you explain how it would break it?

[greenreader9]

Ah, I think I misread the code, stupid GitHub app did not show me what I needed to see.

My apologies, this should actually work.

@mahtab2003 Can you merge this? Thanks

[4yx]

It looks good from my end as well, I'll attempt to test it out.

[gilect-com]

It should work, all it does it changes the directory where SitePro files are created. I applied the change myself and it fixes the SitePro bug that previously occurred.

[4yx]

This should be safe to merge, yes. @mahtab2003 could you reopen and merge this?

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication