mahtoid / DiscordChatExporterPy

A simple Discord chat exporter for Python Discord bots.
GNU General Public License v3.0
209 stars 75 forks source link

Fix CSS/JS Issues + QOL Improvements #108

Closed 1337Syntax closed 6 months ago

1337Syntax commented 6 months ago

Issues Addressed in this PR:

New Features:

1337Syntax commented 6 months ago

Oops, I forgot I was on master branch, my mistake. Reverted those README Changes @mahtoid.

mahtoid commented 6 months ago

It would be good if you could provide screenshots on changed too where applicable. I won't be able to spin up and check anytime soon, so screenshots will give me some sanity 👀

1337Syntax commented 6 months ago

It would be good if you could provide screenshots on changed too where applicable. I won't be able to spin up and check anytime soon, so screenshots will give me some sanity 👀

Here are 2 links to transcripts generated that should hopefully work and show some of the changes.

From those you should be able to see the difference in embed colours, emoji mis-alignment, button padding, footer width, user pop-outs, hover on avatar and scrolling on messages.

For reference, they were generated via the following:

transcript = await chat_exporter.raw_export(
    channel=channel,
    messages=messages,
    tz_info="UTC",
    bot=bot,
    military_time=True,
    fancy_times=True,
    support_dev=False
)

I also did a commit to fix the bug where hovering over a message shows "AM/PM" on the left of it instead of the actual time "MIN:HR".

1337Syntax commented 6 months ago

Thanks for the suggestions @doluk, I've committed those in.

doluk commented 6 months ago

@1337Syntax could you please generate the example again? once with military and once with 12h time format?

1337Syntax commented 6 months ago

@1337Syntax could you please generate the example again? once with military and once with 12h time format?

doluk commented 6 months ago

the time is 24 h in both 🧐

1337Syntax commented 6 months ago

the time is 24 h in both 🧐

Seems that only the timestamp in the aside message part actually checks for military time usage whereas the other timestamps do not. I have pushed a commit to now fix that.

doluk commented 6 months ago

looks good to me now! Thank you for the work and the fast changes!