mahynski / pychemauth

Chemometric analysis methods implemented in python
Other
9 stars 1 forks source link

OutlierMixin #25

Closed mahynski closed 1 week ago

mahynski commented 1 month ago

SIMCA_Model and EllipticManifold_Model are possibly better classed as outlier detectors so should inherit OutlierMixIn from sklearn not Classifier mixins. Consider changing this. The *_Authenticator versions can be kept as classifiers since that is more consistent with how the end user will apply them.

mahynski commented 1 week ago

Outlier mixin convention is to set -1 = outlier vs +1 as inlier during prediction (https://scikit-learn.org/dev/modules/generated/sklearn.base.OutlierMixin.html#sklearn.base.OutlierMixin). I prefer the True/False boolean convention since it makes other steps, like screening outliers etc. simpler and more sensible. In addition, outlier detectors are also distinguished from novelty detectors in sklearn; this convention is not always clearly transferrable to many of our applications so for now, we will leave these as "classifiers" not "outlier detectors".