search

maidsafe-archive / MaidSafe-RUDP

Implementation of Reliable UDP
Other
95 stars 51 forks source link

Removed use of GetRandomPort in socket_test.cc #45

Closed inetic closed 9 years ago

inetic commented 9 years ago

I believe they cause some test failures, e.g. this one:

http://dash.maidsafe.net/testDetails.php?test=2916138&build=76784

jenkinsmaidsafe commented 9 years ago

Can one of the admins verify this patch?

jenkinsmaidsafe commented 9 years ago

OK to test

jenkinsmaidsafe commented 9 years ago

test this please

jenkinsmaidsafe commented 9 years ago

Builds Triggered; CAREFUL: positive marking does not reflect build or test results! Refer to this link for build results: http://ci.maidsafe.net:8080/job/ms_rudp_ghpr/58/

ned14 commented 9 years ago

Seems fine. Where does the GetLocalIp() function come from?

inetic commented 9 years ago

@ned14 , the GetLocalIp() is defined in common/src/maidsafe/common/utils.cc. Normally one should use boost::asio::ip::v4() instead, but there is an assertion inside RUDP which prevents that. Since it looks like our attention should be shifting to Maidsafe-CRUX, I did not care much.

jenkinsmaidsafe commented 9 years ago

Can one of the admins verify this patch?