search

maidsafe-archive / MaidSafe

This is the super-project in which each MaidSafe library resides. Some information is common to all libraries, and is detailed here. Library-specific information can be found in each library's wiki.
Other
583 stars 102 forks source link

Added CMakeLists.txt for Cereal. #152

Closed Fraser999 closed 10 years ago

Fraser999 commented 10 years ago

Despite the apparent huge diff, I suspect this is once again git's line-ending randomiser at play.

The only deliberate change I made with regards to the Cereal files was to move them all into a new folder /include/cereal (to avoid having to add the third_party_libs folder as a compiler search path), and to add a couple of MSVC pragmas in https://github.com/Fraser999/MaidSafe/compare/MAID-59_cereal_cmake?expand=1#diff-16 to disable an MSVC warning.

ned14 commented 10 years ago

You really should bite the bullet and do the .gitattributes conversion, then EOL issues go away forever.

dirvine commented 10 years ago

I thought we already had the include sorted as that is how cryptopp is set up. Does this not break the installers?

Fraser999 commented 10 years ago

@ned14 - true - I've added a Jira task for this. @dirvine - good point, thanks. Should be fixed now.

benjaminbollen commented 10 years ago

Apparently it breaks everything, OSX, Win and Linux

dirvine commented 10 years ago

I am not seeing that, do you have the error message ?

dirvine commented 10 years ago

I can revert the commit in the meantime

benjaminbollen commented 10 years ago

Windows http://dash.maidsafe.net/viewConfigure.php?buildid=61960 Linux http://dash.maidsafe.net/viewConfigure.php?buildid=61958 OSX http://dash.maidsafe.net/viewConfigure.php?buildid=61959

and there's a broken workflow for MAID-59 ;-)