maidsafe-archive / MaidSafe

This is the super-project in which each MaidSafe library resides. Some information is common to all libraries, and is detailed here. Library-specific information can be found in each library's wiki.
Other
583 stars 101 forks source link

Check whether target exists #190

Closed benjaminbollen closed 9 years ago

benjaminbollen commented 9 years ago

Check whether target exists before adding it to the list for installers targets. In particular for when -DINCLUDE_TESTS=Off

jenkinsmaidsafe commented 9 years ago

test this please

Viv-Rajkumar commented 9 years ago

Considering Utilities Installer target only has executable's and these executable's are only tests shouldn't we also just remove the Type "Utilities" from Types when INCLUDE_TESTS=Off. Guessing right now this exposes a Utilities-Installer target which generates an empty package.

benjaminbollen commented 9 years ago

Utilities might be extended later with tools? I agree it is not very elegant, an empty target when INCLUDE_TESTS=Off.

Viv-Rajkumar commented 9 years ago

Yeh it could be extended but we should be enabling it when it isn't empty than expose an empty installer target

benjaminbollen commented 9 years ago

Amended, to be removed once the Utilities target is extended.