maidsafe-archive / MaidSafe

This is the super-project in which each MaidSafe library resides. Some information is common to all libraries, and is detailed here. Library-specific information can be found in each library's wiki.
Other
583 stars 101 forks source link

Include sqlite.h CMAKE Error #198

Open itay-grudev opened 9 years ago

itay-grudev commented 9 years ago

Hi, I was building and installing MaidSafe on Mac OS X and I encountered the following error while executing sudo make install:

CMake Error at src/third_party_libs/sqlite/cmake_install.cmake:41 (file):
  file INSTALL cannot find
  "/Users/me/Projects/MaidSafe/src/third_party_libs/sqlite/include/sqlite.h".
Call Stack (most recent call first):
  src/third_party_libs/cmake_install.cmake:46 (include)
  cmake_install.cmake:32 (include)

The fix is very simple - replace the following line in: build_maidsafe/src/third_party_libs/sqlite/cmake_install.cmake

file(INSTALL DESTINATION "${CMAKE_INSTALL_PREFIX}/include/maidsafe/third_party_libs/sqlite" TYPE FILE FILES "/Users/me/Projects/MaidSafe/src/third_party_libs/sqlite/include/sqlite.h")

with

file(INSTALL DESTINATION "${CMAKE_INSTALL_PREFIX}/include/maidsafe/third_party_libs/sqlite" TYPE FILE FILES "/Users/me/Projects/MaidSafe/src/third_party_libs/sqlite/include/sqlite3.h")

I tried to fix it and make a pull request but I was unable to find the source file I was supposed to change.

benjaminbollen commented 9 years ago

Hi, thanks for pointing out the bug in our cmake. There are currently no installers for mac OSX and we will not be using the cmake install machinerie. So I might rather disable the install target altogether. I'll raise a bug.

If you want to build the code base on OSX you can follow these instructions: https://github.com/maidsafe/MaidSafe/wiki/Build-Instructions-for-OS-X

to build release installers we currently use the compiler flags -DCMAKE_BUILD_TYPE=Release -DINCLUDE_TESTS=Off (best on Linux)

benjaminbollen commented 9 years ago

https://maidsafe.atlassian.net/browse/MAID-663

itay-grudev commented 9 years ago

Why not? The installer works just fine on Mac OS X. The only problem is a tiny bug which takes a minute to fix.

P.S. I was following the tutorial up to that point.