search

maidsafe-archive / MaidSafe

This is the super-project in which each MaidSafe library resides. Some information is common to all libraries, and is detailed here. Library-specific information can be found in each library's wiki.
Other
583 stars 101 forks source link

Maid 714: Stop Protobuf generating illegal C++ #203

Closed ned14 closed 9 years ago

ned14 commented 9 years ago

Let me know if the SHA stamping of the submodules is a problem.

Fraser999 commented 9 years ago

I'd prefer if the SHA stamps were removed if possible please NIall.

breese commented 9 years ago

The SHA hashes downs out the code commits, making it difficult to read the git history afterwards. So I also vote for their removal.

ned14 commented 9 years ago

I'll see if I can flatten the SHA stamping commits in git history. Failing that I'll just cherry pick the fix over to a virgin git clone. BTW after signing a contract Google accepted the fix to protobuf, so that's fixed in head now.

ned14 commented 9 years ago

Cool, that worked.

Fraser999 commented 9 years ago

Thanks Niall.