maidsafe-archive / crust

Reliable p2p network connections in Rust with NAT traversal. One of the most needed libraries for any server-less / decentralised projects
BSD 3-Clause "New" or "Revised" License
955 stars 126 forks source link

`crust_node` example output and usage comments are unhelpful. #65

Closed Fraser999 closed 9 years ago

Fraser999 commented 9 years ago

The comments in crust_node.rs state e.g.

// starting second node : cargo run --example crust_node -- 5883 -b 0.0.0.0:5983

The output from running a crust_node in server mode by doing

target\debug\examples\crust_node.exe -o 6666

yields the following output:

Connection manager now listening on TCP socket 0.0.0.0:6666

However, when connecting another node, we need to use the server's actual IP address, not 0.0.0.0.

Fraser999 commented 9 years ago

Using 0.0.0.0 doesn't seem to be an issue on OS X, and probably isn't a problem on Linux either.

dirvine commented 9 years ago

This means all IP addresses, I think with beacon on a LAN we will be OK, but the node should find it's own IP address for those who connect to it as well. We perhaps require the sniffing logic from rudp and the IANA addresses for checking external IP.

maqi commented 9 years ago

using 0.0.0.0 or 127.0.0.1 or the actually ip address depends on what has been printed out in "add new node

", which might be OS dependent.