search

maidsafe-archive / maidsafe.github.io

19 stars 11 forks source link

MAID-1373 New site footer setup` #63

Closed shankarsengalani closed 8 years ago

shankarsengalani commented 8 years ago

New site footer implemented

Review on Reviewable

hitman401 commented 8 years ago
  1. Typo - Maidsafe should be MaidSafe in the comments in footer.html
  2. Image (https://licensebuttons.net/l/by-sa/4.0/80x15.png) missing in footer
  3. Typo - App Developers in Developers Section in footer
  4. In medium size (iPad layout) the disclaimer, privacy links are centered while it is right justified in the design
  5. In medium screen design the footer links section has more margin (right and left) but in the implementation the margin value seems to be lesser making it closer to the frame of the window.
  6. Better to have separate files for media queries. Managing in one file will be tough moving forward. And also please add a documentation in the media query section to indicate the purpose for overriding/adding behaviour, this will help us to keep a track of things that are being explicitly managed.
  7. Spacing between the Images and the footer headers seems to be more than what is in the images shared in the tasks. similarly on the mobile view the footer links seems to be cramped. But I couldn't find any annotations for the vertical spacing, so am leaving this to Scott. Should be a quick one once Scott confirms
  8. The font weight seems to be lighter in the design for the footer links. Probably Scott could point out here better than me.
shankarsengalani commented 8 years ago

Following issues pointed by @krishnaIndia are fixed 1, 2, 3, 4, 6

Issue 5 - This is same as the one which I have commented on Jira. Requested for annotated mockup.

Issue 7 and 8 - Changes have to be made after Scott's suggestion.

Known issue : In Footer last layer, license button moves to second line below 360px. Scott can you also please provide the annotation for this.