maidsafe-archive / safe_app_nodejs

BSD 3-Clause "New" or "Revised" License
28 stars 23 forks source link

fix(weak): Weak refs via weak-napi. Remove 'weak' #365

Closed joshuef closed 5 years ago

joshuef commented 5 years ago

weak causes errors in newer electron versions

related to https://github.com/maidsafe/safe_browser/issues/410

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.09%) to 96.501% when pulling a783b84ffc6bbcfa407ffc3f2e1cff1d0f6bddbe on joshuef:Fix-WeakRefsForNewV8Engines into eff0f621464f346992ea875fe4372ecde0b6d696 on maidsafe:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.09%) to 96.501% when pulling 7cd82d15131b3461bb252ed12fee7a3f52a79c93 on joshuef:Fix-WeakRefsForNewV8Engines into eff0f621464f346992ea875fe4372ecde0b6d696 on maidsafe:master.