maidsafe-archive / safe_examples

examples showcasing various features of the SAFE Network
BSD 3-Clause "New" or "Revised" License
82 stars 50 forks source link

MAID-2373: separate app-specific reducer cases out of initialiser #304

Closed hunterlester closed 6 years ago

maidsafe-highfive commented 6 years ago

r? @ustulation

(maidsafe_highfive has picked a reviewer for you, use r? to override)

joshuef commented 6 years ago

Just looking this over it seems pretty good.

Couple small things:

With these things set up, we could then move the initialiser files to it's own example folder in the repo (maybe js_authenticator_example or something?), and then symlink those files back into the example (assuming that this works with packaging... it might not).

And then we're set up to do the implement this for webhosting

hunterlester commented 6 years ago

@joshuef Things are looking better, though I need help with symlinks. I created a symlink: symlink_created

But when index.js tries to import network.js via the symlink: cannot_find_module_symlink

I tried import * as network from './network.symlink';, to no avail. Seems like it'll work fine, I'm just missing something.

joshuef commented 6 years ago

@hunterlester let's change example_common_app_utils to example_common_js_app_utils just for clarity (as we've java in the example repo also).

I'm having problems running in prod mode. Seems to keep trying to run the testAuth functionality.

https://www.dropbox.com/s/iqloe6w9zn7ky5n/Screenshot%202017-10-04%2014.08.50.jpg?dl=0