Closed hunterlester closed 6 years ago
Just looking this over it seems pretty good.
Couple small things:
initialiser.js
and mail.js
would be fine.safe_comms.js
for the initialiser.With these things set up, we could then move the initialiser files to it's own example folder in the repo (maybe js_authenticator_example
or something?), and then symlink those files back into the example (assuming that this works with packaging... it might not).
And then we're set up to do the implement this for webhosting
@joshuef Things are looking better, though I need help with symlinks. I created a symlink:
But when index.js
tries to import network.js
via the symlink:
I tried import * as network from './network.symlink';
, to no avail.
Seems like it'll work fine, I'm just missing something.
@hunterlester let's change example_common_app_utils
to example_common_js_app_utils
just for clarity (as we've java in the example repo also).
I'm having problems running in prod mode. Seems to keep trying to run the testAuth
functionality.
https://www.dropbox.com/s/iqloe6w9zn7ky5n/Screenshot%202017-10-04%2014.08.50.jpg?dl=0
r? @ustulation
(maidsafe_highfive has picked a reviewer for you, use r? to override)