search

maidsafe-archive / safe_examples

examples showcasing various features of the SAFE Network
BSD 3-Clause "New" or "Revised" License
82 stars 50 forks source link

MAID-2622: refactor/playground: Change naming in snippet to be consis… #381

Closed hunterlester closed 6 years ago

hunterlester commented 6 years ago

…tent with safe_app_nodejs and web API

maidsafe-highfive commented 6 years ago

r? @ustulation

(maidsafe_highfive has picked a reviewer for you, use r? to override)

bochaco commented 6 years ago

Let's delay this until we have a new formal release of safe_app_nodejs package.

bochaco commented 6 years ago

@hunterlester is it right this is obsolete now due to PR #385 ?

hunterlester commented 6 years ago

@bochaco The minor change that is still relevant with this PR is using delete instead of remove. Which I forgot to do in #385.

bochaco commented 6 years ago

Ok, I see, then this PR should go against the playground3-0 branch

hunterlester commented 6 years ago

@bochaco I'll need a different PR for playground3-0.

bochaco commented 6 years ago

@hunterlester , ok, so I guess you are assuming we are releasing a new version of Beaker with latest safe_app_nodejs, we'll need to decide if we are gonna be doing that or not.

hunterlester commented 6 years ago

@bochaco Right, good point. Here's a separate PR, https://github.com/maidsafe/safe_examples/pull/386, for 3.0.

hunterlester commented 6 years ago

Obsolete PR. Closing.