search

maidsafe-archive / safe_examples

examples showcasing various features of the SAFE Network
BSD 3-Clause "New" or "Revised" License
82 stars 50 forks source link

Vulnerability issue fix #411

Open shankarsengalani opened 5 years ago

shankarsengalani commented 5 years ago

Removed package-lock.json file to get the vulnerability issue fix from github for a dependency's dependency

maidsafe-highfive commented 5 years ago

r? @ustulation

(maidsafe_highfive has picked a reviewer for you, use r? to override)

bochaco commented 5 years ago

The only reason why I didn't introduce yarn was to keep it simple to starters, so they don't need to install yarn, and also for something like this doesn't need to be that efficient as it doesn't download too many things, so I'd vote for keeping it simpler with just npm.

bochaco commented 5 years ago

I was trying to fix this by forcing the version of the nested dependency webpack-dev-server, and after some trouble I seem to understand how to do it using the command npm ci. However the newer version of webpack-dev-server seems to break backward compatibility and I get the following error when trying to run the app with npm start:

{ Error: Cannot find module 'webpack-dev-server/client'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Function.resolve (internal/modules/cjs/helpers.js:32:19)
    at config.entry.batch.entry (/home/bochaco/safe/bochaco-safe_examples/safe_web_app_quick_start/node_modules/@neutrinojs/web/index.js:209:43)
...

So it seems we don't have much choice but to wait for a new release of our direct dependencies where they upgrade webpack-dev-server to >=3.1.11. Any other thoughts/ideas?