search

maidsafe-archive / safe_examples

examples showcasing various features of the SAFE Network
BSD 3-Clause "New" or "Revised" License
82 stars 50 forks source link

Update dependencies #417

Closed lionel-faber closed 5 years ago

lionel-faber commented 5 years ago

Update dependencies to resolve security vulnerabilities.

maidsafe-highfive commented 5 years ago

Thanks for the pull request, and welcome! The MaidSafe team is excited to review your changes, and you should hear from @krishnaIndia (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTOR.md for more information.

lionel-faber commented 5 years ago

Styles are broken and gulp is not functioning as expected. That's strange. They seemed okay to me. Here are the steps I followed.

  • Removed node_modules inside the web API playground
  • Ran yarn to install the packages
  • yarn gulp served the app on localhost:3003 I even uploaded the build dir via WHM and the published sited seemed fine too. Am I going wrong somewhere?
hunterlester commented 5 years ago

@lionel1704 Most likely is that yarn has cached safe_ux_guidelines, so it may be continuing to install for you even though the repo has been deleted.

lionel-faber commented 5 years ago

I did a yarn cache clean and followed the same steps again. Still seems okay to me. @manavbp gave it a try on his machine and it seemed okay there too.

If it's still breaking for you, feel free to raise a PR to my branch.

hunterlester commented 5 years ago

@lionel1704 Okay I'll open a PR on your branch. This is what my styles look like: image

What are the contents of your build directory?

lionel-faber commented 5 years ago

Here you go build.zip

hunterlester commented 5 years ago

@lionel1704 Thank you. main.css still contains scss from the no longer existing safe_ux_guidelines. Did you delete build directory and then run yarn gulp again?

hunterlester commented 5 years ago

@lionel1704 Looking good! Thanks, Lionel. Last thing is to update the gulpfile: https://github.com/lionel1704/safe_examples/pull/1

lionel-faber commented 5 years ago

@S-Coyle can we have this merged please?