search

maidsafe-archive / sentinel

p2p group based consensus
Other
13 stars 11 forks source link

Implement keystore and add tests for it #16

Closed inetic closed 9 years ago

inetic commented 9 years ago

implement: maid 1022 test: maid 1023

Review on Reviewable

maidsafe-highfive commented 9 years ago

r? @benjaminbollen

(maidsafe_highfive has picked a reviewer for you, use r? to override)

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.42%) to 99.38% when pulling 580094373a8c1ddd68f917908de6b1f5c5fb57f2 on inetic:MAID-1022-implement-keystore into 06ae55b552441dbeaa7c3832e5bea65f313e8fe8 on maidsafe:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.42%) to 99.38% when pulling 580094373a8c1ddd68f917908de6b1f5c5fb57f2 on inetic:MAID-1022-implement-keystore into 06ae55b552441dbeaa7c3832e5bea65f313e8fe8 on maidsafe:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.42%) to 99.38% when pulling 05e347fa3ecdcefb9bb7fb4aede61b187fc3418b on inetic:MAID-1022-implement-keystore into 06ae55b552441dbeaa7c3832e5bea65f313e8fe8 on maidsafe:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.42%) to 99.38% when pulling 05e347fa3ecdcefb9bb7fb4aede61b187fc3418b on inetic:MAID-1022-implement-keystore into 06ae55b552441dbeaa7c3832e5bea65f313e8fe8 on maidsafe:master.

benjaminbollen commented 9 years ago

Nice work. I appreciate the fact that you check the self_signing. Also that you keep a set of the senders. That will be useful later on, when we want to derank nodes that provided false information.

dirvine commented 9 years ago

For sure, also when a node asks to Get something that is not there (especially StructuredData) it would be nice to filter the node for 10/20 minutes.

dirvine commented 9 years ago

What I mean is that if vaults or any upper layer returned a RoutingError::BanNode It then allows routing to make decisions on behaviour but also upper layers as well. Therefor we have routing rank etc. and vault rank (in our case) which is very neat.