Maid 1024 pure sentinel - Githubissues

maidsafe-archive / sentinel

p2p group based consensus

Other

13 stars 11 forks source link

Maid 1024 pure sentinel #17

Closed inetic closed 9 years ago

inetic commented 9 years ago

maidsafe-highfive commented 9 years ago

r? @benjaminbollen

(maidsafe_highfive has picked a reviewer for you, use r? to override)

maidsafe-highfive commented 9 years ago

OS X Build failed

maidsafe-highfive commented 9 years ago

Windows Build failed

maidsafe-highfive commented 9 years ago

OS X Build Successful

coveralls commented 9 years ago

Coverage increased (+0.62%) to 100.0% when pulling 612683f32f67ada62281e94e793707240d360d90 on inetic:MAID-1024-pure-sentinel into 393460673d02ec321b704da593400ec92e8c72dc on maidsafe:master.

coveralls commented 9 years ago

Coverage increased (+0.62%) to 100.0% when pulling 612683f32f67ada62281e94e793707240d360d90 on inetic:MAID-1024-pure-sentinel into 393460673d02ec321b704da593400ec92e8c72dc on maidsafe:master.

benjaminbollen commented 9 years ago

great work. will merge when those minor remarks are pushed

coveralls commented 9 years ago

Coverage increased (+0.62%) to 100.0% when pulling 251ad12630c243c75186220d2c396ee985b64109 on inetic:MAID-1024-pure-sentinel into 393460673d02ec321b704da593400ec92e8c72dc on maidsafe:master.

coveralls commented 9 years ago

Coverage increased (+0.62%) to 100.0% when pulling 89c03b4c07992b462d22a2152a17f01808ad20b6 on inetic:MAID-1024-pure-sentinel into 393460673d02ec321b704da593400ec92e8c72dc on maidsafe:master.

inetic commented 9 years ago

I think you're right. I must have gotten confused (I blame it on me working late :) ). I guess I should use the debug_assert macro instead of the assert one then (apart from switching back to using the Frequency structure).

coveralls commented 9 years ago

Coverage increased (+0.62%) to 100.0% when pulling b51d935fdcf287383ff49aba4deb36b5fb6d9ac3 on inetic:MAID-1024-pure-sentinel into 393460673d02ec321b704da593400ec92e8c72dc on maidsafe:master.

benjaminbollen commented 9 years ago

perfect, thanks Peter! great work

coveralls commented 9 years ago

Coverage increased (+0.62%) to 100.0% when pulling 52ec1f90fafe79a7d42e3f69ee78fc77798588f7 on inetic:MAID-1024-pure-sentinel into 393460673d02ec321b704da593400ec92e8c72dc on maidsafe:master.

coveralls commented 9 years ago

Coverage increased (+0.62%) to 100.0% when pulling 52ec1f90fafe79a7d42e3f69ee78fc77798588f7 on inetic:MAID-1024-pure-sentinel into 393460673d02ec321b704da593400ec92e8c72dc on maidsafe:master.