maidsafe-archive / sentinel

p2p group based consensus
Other
13 stars 11 forks source link

Maid 1025: Test Pure Sentinel #18

Closed mmoadeli closed 9 years ago

mmoadeli commented 9 years ago

The test passed for sentinel<1, 1> where one claim is followed by one key being sent. For sentinel<10, 10> sending 10 claims and, 10 claimant send public key of the 10 climants should provide 10X10 entries which should suffice for it to pass, while it does not. To avoid code duplicates, a number of tests are presented in one test. They can be separated if it is required.

Review on Reviewable

maidsafe-highfive commented 9 years ago

Thanks for the pull request, and welcome! The MaidSafe team is excited to review your changes, and you should hear from @benjaminbollen (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTOR.md for more information.

benjaminbollen commented 9 years ago

sorry I just noticed this

mmoadeli commented 9 years ago

the asserts are replaced. thanks for the comments

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-2.26%) to 97.74% when pulling 6f901066d848dc7e01ca04f8f5355ad64403260a on mmoadeli:MAID-1025 into 063102011fe18f6393039ec1a29a9d1cede19ad4 on maidsafe:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-2.26%) to 97.74% when pulling 991b98cae922c2f41be54590fc3dc3df20c914b5 on mmoadeli:MAID-1025 into 063102011fe18f6393039ec1a29a9d1cede19ad4 on maidsafe:master.

mmoadeli commented 9 years ago

It is ready for review

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-2.26%) to 97.74% when pulling 991b98cae922c2f41be54590fc3dc3df20c914b5 on mmoadeli:MAID-1025 into 063102011fe18f6393039ec1a29a9d1cede19ad4 on maidsafe:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-2.26%) to 97.74% when pulling 991b98cae922c2f41be54590fc3dc3df20c914b5 on mmoadeli:MAID-1025 into 063102011fe18f6393039ec1a29a9d1cede19ad4 on maidsafe:master.