search

maidsafe-archive / sentinel

p2p group based consensus
Other
13 stars 11 forks source link

WIP Implement Sentinel #2

Closed benjaminbollen closed 9 years ago

benjaminbollen commented 9 years ago

Review on Reviewable

dirvine commented 9 years ago

Cool, if you and Brian can get this up to speed tomorrow we can had it over to the library maintainer (name to be disclosed later :-) )

dirvine commented 9 years ago

README.md, line 19 [r2] (raw file): Should sentinel not actually do the merge itself ?

Comments from the review on Reviewable.io

benjaminbollen commented 9 years ago

Sentinel will merge the keys, but by pushing the merge function of claims out of sentinel, sentinel does not have to care about message types and instead it can be handled by an exhaustive static match statement in routing itself