Reworks sentinel implementation as separate module.

maidsafe-archive / sentinel

p2p group based consensus

Other

13 stars 11 forks source link

Reworks sentinel implementation as separate module. #6

Closed ghost closed 9 years ago

ghost commented 9 years ago

Adds validation and resolution functions for mergeable and non-mergeable types.

dirvine commented 9 years ago

Nice on Brian, is Ben doing the tests now?

Reviewed files:

src/lib.rs @ r1

Comments from the review on Reviewable.io

ghost commented 9 years ago

Yes, he said he's working on the tests now.

ghost commented 9 years ago

Now that the initial part is in. Do we want at least a quorum of quorum keys to be returned before we validate and resolve, or are we not fussed about that at the moment.

dirvine commented 9 years ago

I feel we should aim for quorum of quorum keys and check tests and confirm logic.

ghost commented 9 years ago

I'll update the PR with that.

ghost commented 9 years ago

This one is good to go now David.