maidsafe / lru_time_cache

LRU cache settable via size or time to live
BSD 3-Clause "New" or "Revised" License
104 stars 46 forks source link

private_no_mangle_fns/statics lints are removed in Rust 1.31 #110

Closed cuviper closed 5 years ago

cuviper commented 5 years ago
$ rustc -V
rustc 1.31.0 (abe02cefd 2018-12-04)
$ cargo build
   Compiling lru_time_cache v0.8.0 (/home/jistone/rust/lru_time_cache)
error: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported`
  --> src/lib.rs:59:5
   |
59 |     private_no_mangle_fns,
   |     ^^^^^^^^^^^^^^^^^^^^^
   |
note: lint level defined here
  --> src/lib.rs:50:5
   |
50 |     warnings
   |     ^^^^^^^^
   = note: #[forbid(renamed_and_removed_lints)] implied by #[forbid(warnings)]

error: lint `private_no_mangle_statics` has been removed: `no longer an warning, #[no_mangle] statics always exported`
  --> src/lib.rs:60:5
   |
60 |     private_no_mangle_statics,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

error: Could not compile `lru_time_cache`.

To learn more, run the command again with --verbose.
pierrechevalier83 commented 5 years ago

Thanks for raising this, @cupiver. Should be addressed by PR 112

pierrechevalier83 commented 5 years ago

The PR got merged. This is now fixed on master.