Disable PIE for non-Ubuntu distros

maidsafe / rust_sodium

This crate is no longer maintained. Looking for maintainers.

BSD 3-Clause "New" or "Revised" License

77 stars 34 forks source link

Disable PIE for non-Ubuntu distros #34

Closed ffflorian closed 7 years ago

ffflorian commented 7 years ago

In reference to my comment this commit will disable PIE for non-Ubuntu distros again. Tested on Debian 9.

Or should I better disable it for Debian only?

ustulation commented 7 years ago

@ffflorian I think should be OK to just disable the way you did as IDK how many other platforms would face the same issue and then instead of catering to all, we'll just disable PIE for now. However i think sometime in the future we should move to not disabling PIE and if ppl face problems in their specific platforms, they can just do it for their builds (we'll mention it in the README or some place when we change it).

ffflorian commented 7 years ago

@ustulation Sounds good, thanks!